Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security requirement to root OpenAPI V3 #432

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Add security requirement to root OpenAPI V3 #432

merged 1 commit into from
Sep 28, 2023

Conversation

Jefftree
Copy link
Member

While looking into k8s authentication, noticed this field should be used but is missing from the OpenAPI V3. See https://spec.openapis.org/oas/v3.0.0#openapi-object and https://spec.openapis.org/oas/v3.0.0#securityRequirementObject

/assign @apelisse

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 28, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2023
@Jefftree Jefftree force-pushed the add-security-requirement-v3 branch 2 times, most recently from 75d10c8 to 870b882 Compare September 28, 2023 16:43
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2023
@apelisse
Copy link
Member

apelisse commented Sep 28, 2023 •
edited
Loading

Do we have corresponding fields for this in OpenAPI v2?

EDIT: Sorry, I should have looked at the patch beforehand. I thought they were values, not fields :-)

@Jefftree
Copy link
Member Author

Yes this field is already present and used in v2. swagger.json contains an extra

  "security": [
    {
      "BearerToken": []
    }
  ],

that is not present in the v3 json. How many people rely on this -shrug-, but it's good to be consistent.

@Jefftree Jefftree force-pushed the add-security-requirement-v3 branch from 870b882 to ce36a0c Compare September 28, 2023 19:54
@Jefftree
Copy link
Member Author

@apelisse fixed the CI :)

@apelisse
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, Jefftree

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a781456 into kubernetes:master Sep 28, 2023
@Jefftree Jefftree mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jefftree @apelisse @k8s-ci-robot